Support GHC 9.6 - #557
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
a28e9ad to
e78a8f7
Compare
addf2a2 to
8f17944
Compare
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D78210367. |
|
Please stack this one on top of "Enable -Werror" |
done |
pepeiborra
left a comment
pepeiborra
left a comment
There was a problem hiding this comment.
Do you want to fix the dodgy imports or should we make it a warning?
| constraints: entropy < 0.4.1.9 | ||
| -- develop with -Werror on, for consistency with internal Meta CI. | ||
| program-options | ||
| ghc-options: -Werror -Wwarn=dodgy-imports |
There was a problem hiding this comment.
Internally, dodgy-imports is an error not a warning.
There was a problem hiding this comment.
Yeah ok, unfortunately I'll have to use some #ifdefs because the Prelude exports changed between GHC versions. Really -Wwarn=dodgy-imports is the right thing because it avoids the need for CPP, but it's not a big deal.
|
|
||
| module Glean.Database.Env ( withDatabases ) where | ||
|
|
||
| import Prelude hiding (liftA2) |
There was a problem hiding this comment.
This PR fails internal CI due to this hiding directive
e65be1e to
59e975a
Compare
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D78210367. |
3 participants
No description provided.